Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force connection closure when pool is stopped #2631

Merged

Conversation

@jrudolph
Copy link
Member

commented Aug 1, 2019

Otherwise, those connections might hang around for a while when a request is ongoing and the client flow isn't expecting or reacting to completion or cancellation.

@akka-ci akka-ci added validating tested and removed validating labels Aug 1, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

Test PASSed.

Copy link
Member

left a comment

Good improvement, perhaps we're still closing without failure in too many cases though?

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

Test FAILed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

Test PASSed.

jrudolph added 6 commits Aug 1, 2019
…is stopped
@jrudolph jrudolph force-pushed the jrudolph:jr/force-connection-closure-when-pool-is-stopped branch from 1ba9ca8 to bf04cce Aug 13, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

Test PASSed.

@raboof
raboof approved these changes Aug 13, 2019
Copy link
Member

left a comment

Nice with the clearer logging

@jrudolph jrudolph merged commit b8b3b7f into akka:master Aug 14, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation Test PASSed. 4165 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph deleted the jrudolph:jr/force-connection-closure-when-pool-is-stopped branch Aug 14, 2019
@jrudolph jrudolph added this to the 10.1.10 milestone Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.