Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Disallow entity for 205 status code #2686
Disallow entity for 205 status code as response with this status code should contain empty content.
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.
For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!
raboof left a comment •
(sorry, did not read the linked issue yet)
raboof left a comment
I agree with the change, given that without this setting we automatically generate a body even though the RFC explicitly forbids it.
This does mean any applications that (admittedly incorrectly) relied on sending 205 responses with entity bodies would now no longer work.
That sounds unlikely to be common, but I do think it would be good to mention this in the release notes. Could you add such a mention to this PR?