Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: fix receiving HEADERS with more than one CONTINUATION frame #2701

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@jrudolph
Copy link
Member

commented Sep 11, 2019

I guess no one has noticed so far because it only shows starting from HEADER blocks with more than 2 * frame size.

@jrudolph jrudolph requested a review from raboof Sep 11, 2019
@akka-ci akka-ci added validating tested and removed validating labels Sep 11, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

Test PASSed.

@raboof
raboof approved these changes Sep 11, 2019
Copy link
Member

left a comment

LGTM

@@ -134,15 +134,17 @@ class Http2ServerSpec extends AkkaSpecWithMaterializer("""
expectedResponseHeaderBlock = HPackSpecExamples.C63ThirdResponseWithHuffman
)
}
"GET request in one HEADERS and one CONTINUATION frame" in new TestSetup with RequestResponseProbes {
"GET request in one HEADERS and two CONTINUATION frames" in new TestSetup with RequestResponseProbes {

This comment has been minimized.

Copy link
@johanandren

johanandren Sep 12, 2019

Member

Wasn't the old test case also useful to keep?

@raboof raboof self-assigned this Sep 13, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Sep 16, 2019

Test PASSed.

Pull request validation report

@raboof raboof merged commit 27f1296 into akka:master Sep 17, 2019
3 of 4 checks passed
3 of 4 checks passed
Jenkins PR Auto-Formatter Failed
Details
Jenkins PR Validation Test PASSed. 1619 tests run, 977 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@raboof raboof added this to the 10.1.10 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.