Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: collapse PR validation report for less clutter #2707

Merged
merged 3 commits into from Sep 27, 2019

Conversation

@jrudolph
Copy link
Member

jrudolph commented Sep 12, 2019

I just turned on the PR validation reports I developed a long time ago (which needed a fix in the jenkins github pr validator plugin which was released only a long time afterwards). To prevent too much clutter this PR collapses the report by default.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Sep 12, 2019

Test FAILed.

!!! Couldn't read commit file !!!

@jrudolph jrudolph force-pushed the jrudolph:collapse-pr-report branch from 33b5666 to 2904db9 Sep 12, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Sep 12, 2019

Test PASSed.

@raboof
raboof approved these changes Sep 13, 2019
Copy link
Member

raboof left a comment

Good start. Eventually perhaps it would be even clearer to show the headings and only collapse the content (so you'd see there's mima errors, but would have to expand to see the actual errors), but that can be a future improvement.

write("")
write("# Pull request validation report")
write("")
if (failed.nonEmpty || mimaFailures.nonEmpty || failedTasks.nonEmpty) {

This comment has been minimized.

Copy link
@raboof

raboof Sep 13, 2019

Member

Perhaps we should write an empty file otherwise?

@jrudolph

This comment has been minimized.

Copy link
Member Author

jrudolph commented Sep 26, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Sep 26, 2019

Test PASSed.

@jrudolph jrudolph force-pushed the jrudolph:collapse-pr-report branch from d9cb6e2 to ea0cc47 Sep 26, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Sep 26, 2019

Test PASSed.

@raboof
raboof approved these changes Sep 27, 2019
Copy link
Member

raboof left a comment

Love it!

@raboof raboof merged commit 68cfd8f into akka:master Sep 27, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation Test PASSed. 4173 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.