Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending an ack SETTINGS frame immediately #2735

Merged
merged 3 commits into from Oct 7, 2019
Merged

Conversation

@raboof
Copy link
Member

raboof commented Oct 1, 2019

Might fix #2734

@akka-ci akka-ci added the validating label Oct 1, 2019
Might fix #2734
@raboof raboof force-pushed the allowImmediateAck branch from 02cb675 to 90de871 Oct 1, 2019
@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Oct 1, 2019

I guess we need to rewrite that test at some point using all of our testing tools. Could you also enable WithLogCapturing and frame-logging for that test so we see more when it fails the next time?

@akka-ci akka-ci added tested and removed validating labels Oct 1, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 1, 2019

Test PASSed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 1, 2019

Test PASSed.

@@ -16,10 +17,11 @@ import akka.util.ByteString
import scala.concurrent.Future

class WithPriorKnowledgeSpec extends AkkaSpec("""
akka.loglevel = warning
akka.loglevel = debug
akka.loggers = ["akka.testkit.TestEventListener"]

This comment has been minimized.

Copy link
@jrudolph

jrudolph Oct 1, 2019

Member

It also need the SilenceAll... listener, otherwise, stuff will still be printed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 4, 2019

Test PASSed.

Copy link
Member

jrudolph left a comment

LGTM (though, I don't completely understand what's going on there).

@jrudolph jrudolph merged commit 261a70a into master Oct 7, 2019
5 checks passed
5 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation Test PASSed. 1619 tests run, 977 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph deleted the allowImmediateAck branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.