Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2409/hide `HttpEntity.Strict` body data by default #2736

Closed

Conversation

@pfcoperez
Copy link

commented Oct 1, 2019

Purpose

Aimed to avoid PII and SPI leakage, partially tackles #2409

References

References #2560
References #2412
References #2409 (comment)
References #2412 (review)

Changes

This PR makes HttpEntity.Strict#toString method to print just the entity content type and its contents size. Replacing the previous behaviour which included the whole contents (or their beginning if they were excessively long).

Background Context

#2560 (review)

avoid including body data from strict entities (not a good idea anyways)

@pfcoperez pfcoperez closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.