Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typed sample polish #2784

Merged
merged 4 commits into from Nov 18, 2019
Merged

docs: typed sample polish #2784

merged 4 commits into from Nov 18, 2019

Conversation

@johanandren
Copy link
Member

johanandren commented Oct 23, 2019

Hold this PR until the quickstart update is done. I think we may want to link to that instead, or align this sample with that when it is done for 2.6

Refs #2781

  • mostly works with both 2.5.26 and 2.6.0-RC (requires a few small changes)
  • updated to follow styleguide closer
  • made it a runnable instead of a compile-only test
  • a bit closer to what a real(tm) server wrapping actor would have to do

There are a few source incompatibilities for typed making crossbuilding impossible.
Not sure if we should really try to address those or just live with that
something marked @MayChange are not 100% compatible. Not actually sure that we even can make it source compatible because of the implicits becoming ambigous.

johanandren added 2 commits Oct 23, 2019
 * mostly works with both 2.5.26 and 2.6.0-RC (requires a few small changes)
 * updated to follow styleguide closer
 * made it a runnable instead of a compile-only test
 * a bit closer to what a real(tm) server wrapping actor would have to do
@akka-ci akka-ci added the validating label Oct 23, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 23, 2019

Test PASSed.

@johanandren johanandren marked this pull request as ready for review Oct 23, 2019
@johanandren

This comment has been minimized.

Copy link
Member Author

johanandren commented Oct 23, 2019

I'll do the Java part as well, but would want this LGTM:ed first since that will be as close to 1:1 with this sample as possible.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 23, 2019

Test PASSed.

@johanandren

This comment has been minimized.

Copy link
Member Author

johanandren commented Oct 28, 2019

Created #2790 to discuss some of the problems I found here

@jlprat
jlprat approved these changes Nov 12, 2019
Copy link
Member

jlprat left a comment

LGTM

}
//#akka-typed-route

/* there are still differences making this impossible to compile both for 2.5 and 2.6 at the same time

This comment has been minimized.

Copy link
@jrudolph

jrudolph Nov 18, 2019

Member

So, for now, this would compile correctly in the regular build, but would fail building against 2.6 master.

Copy link
Member

jrudolph left a comment

LGTM

@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Nov 18, 2019

@johanandren I guess we can merge that now? It won't be published until 10.1.11 anyway.

@johanandren

This comment has been minimized.

Copy link
Member Author

johanandren commented Nov 18, 2019

Yeah I think so, not perfect but better than before!

@jrudolph jrudolph changed the title Typed sample polish docs: typed sample polish Nov 18, 2019
@jrudolph jrudolph merged commit 52c28dc into akka:master Nov 18, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation 4176 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph added this to the 10.1.11 milestone Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.