Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: improve "Entity stream truncation" error message #2789

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@jrudolph
Copy link
Member

jrudolph commented Oct 28, 2019

Refs #2786

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 28, 2019

Test FAILed.

!!! Couldn't read commit file !!!

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 28, 2019

Test FAILed.

Pull request validation report

Failed Test Suites

Test result for 'akka-http-core / Pr-validation / ./ executeTests'

[info] ScalaTest
[info] Run completed in 1 minute, 57 seconds.
[info] Total number of tests run: 1030
[info] Suites: completed 73, aborted 0  Scopes: pending 1
[info] Tests: succeeded 1024, failed 6, canceled 1, ignored 2, pending 56
[info] *** 6 TESTS FAILED ***
[error] Failed: Total 1030, Failed 6, Errors 0, Passed 1024, Ignored 2, Canceled 1, Pending 56
[error] Failed tests:
[error] 	akka.http.impl.engine.parsing.ResponseParserLFSpec
[error] 	akka.http.impl.engine.server.HttpServerSpec
[error] 	akka.http.scaladsl.GracefulTerminationSpec
[error] 	akka.http.impl.engine.parsing.ResponseParserCRLFSpec
[error] 	akka.http.impl.engine.client.ResponseParsingMergeSpec
Refs #2786
@jrudolph jrudolph force-pushed the jrudolph:2786-better-error-message branch from 6c8636a to d46130d Nov 18, 2019
@jrudolph

This comment has been minimized.

Copy link
Member Author

jrudolph commented Nov 18, 2019

Fixed test assertions.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 18, 2019

Test PASSed.

@raboof
raboof approved these changes Nov 20, 2019
@jrudolph jrudolph merged commit 095949f into akka:master Nov 20, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation 1088 tests run, 58 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.