Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WS masking performance #2801

Merged

Conversation

@jrudolph
Copy link
Member

jrudolph commented Nov 5, 2019

On top of #2780

It now masks 4 bytes together and also avoids an extra buffer copy at the end by using ByteString.fromArrayUnsafe.

(It cannot fix the 2.13 performance problem because ByteString.toArray is still used)

jrudolph added 3 commits Nov 5, 2019
Now masking always processes 4 bytes together (if possible). Also, an extra
buffer copy was removed by using ByteString.fromArrayUnsafe.
@akka-ci akka-ci added validating tested and removed validating labels Nov 5, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 5, 2019

Test PASSed.

@jrudolph

This comment has been minimized.

Copy link
Member Author

jrudolph commented Nov 5, 2019

Copy link
Member

johanandren left a comment

LGTM

@raboof raboof requested a review from johanandren Nov 5, 2019
@raboof
raboof approved these changes Nov 5, 2019
Copy link
Member

raboof left a comment

Neat!

@jrudolph jrudolph merged commit 862efef into akka:master Nov 5, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation 1089 tests run, 58 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph deleted the jrudolph:2788-investigate-websocket-perf-slowdown branch Nov 5, 2019
@jrudolph

This comment has been minimized.

Copy link
Member Author

jrudolph commented Nov 5, 2019

Refs #2788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.