Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update naming for status codes 413, 414, 416 and 505 #2808

Merged
merged 3 commits into from Nov 18, 2019

Conversation

@Philippus
Copy link
Contributor

Philippus commented Nov 9, 2019

For status codes 413, 414 and 416 older names from older RFCs are currently used, I updated them to follow the naming in RFC 7231 and RFC 7233.
For status code 505 the Scala naming convention was not followed.
I deprecated the older names.
I decided to leave OK (which also doesn't follow the naming convention) as is, because that probably would mean a lot of changes downstream.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 9, 2019

Test FAILed.

Pull request validation report

Failed Test Suites

Test result for 'akka-http-core / Pr-validation / ./ executeTests'

[info] ScalaTest
[info] Run completed in 3 minutes, 55 seconds.
[info] Total number of tests run: 1030
[info] Suites: completed 73, aborted 0  Scopes: pending 1
[info] Tests: succeeded 1020, failed 10, canceled 1, ignored 2, pending 56
[info] *** 10 TESTS FAILED ***
[error] Failed: Total 1030, Failed 10, Errors 0, Passed 1020, Ignored 2, Canceled 1, Pending 56
[error] Failed tests:
[error] 	akka.http.impl.engine.server.HttpServerSpec
Philippus added 2 commits Nov 9, 2019
@Philippus Philippus force-pushed the Philippus:update-status-code-vals branch from d036580 to 11b5324 Nov 9, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 9, 2019

Test PASSed.

Copy link
Member

jrudolph left a comment

I'm fine with doing this change. Could you change all the deprecation messages to include the exact symbol name?

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 18, 2019

Test PASSed.

Copy link
Member

jrudolph left a comment

LGTM, thanks a lot, @Philippus.

@jrudolph jrudolph merged commit 534ea25 into akka:master Nov 18, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation 4177 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph added this to the 10.1.11 milestone Nov 18, 2019
@Philippus Philippus deleted the Philippus:update-status-code-vals branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.