Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use more resilient checking for Scala 2.13 in Mima #2820

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@jrudolph
Copy link
Member

jrudolph commented Nov 19, 2019

Fix #2819

The real issue is that nightlies were using ++2.13.0 last night.

Fix #2819
@akka-ci akka-ci added the validating label Nov 19, 2019
@jrudolph jrudolph requested a review from raboof Nov 19, 2019
@akka-ci akka-ci added tested and removed validating labels Nov 19, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 19, 2019

Test PASSed.

@raboof

This comment has been minimized.

Copy link
Member

raboof commented Nov 19, 2019

I thought there was something in sbt that'd prevent choosing ++2.13.0 when crossScalaVersions does not contain that version... apparently not?

LGTM, but if we can instead prevent switching to versions not in the list I'd prefer that

@jrudolph

This comment has been minimized.

Copy link
Member Author

jrudolph commented Nov 19, 2019

LGTM, but if we can instead prevent switching to versions not in the list I'd prefer that

That's a good point, I was also surprised that the check doesn't seem to be there any more.

@raboof
raboof approved these changes Nov 22, 2019
Copy link
Member

raboof left a comment

I cannot find any references to that check anymore :/

@raboof raboof merged commit 80f197e into akka:master Nov 22, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation 4179 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.