Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EntityStreamSizeException message #2823

Merged
merged 2 commits into from Nov 25, 2019
Merged

Conversation

@raboof
Copy link
Member

raboof commented Nov 22, 2019

Refs #2741

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 22, 2019

Test FAILed.

Pull request validation report

Failed Test Suites

Test result for 'akka-http-core / Pr-validation / ./ executeTests'

[info] ScalaTest
[info] Run completed in 2 minutes, 1 second.
[info] Total number of tests run: 1030
[info] Suites: completed 73, aborted 0  Scopes: pending 1
[info] Tests: succeeded 1020, failed 10, canceled 1, ignored 2, pending 56
[info] *** 10 TESTS FAILED ***
[error] Failed: Total 1030, Failed 10, Errors 0, Passed 1020, Ignored 2, Canceled 1, Pending 56
[error] Failed tests:
[error] 	akka.http.impl.engine.server.HttpServerSpec
@raboof raboof force-pushed the EntityStreamSizeExceptionMessage branch from d0aa4fd to 0b0c8eb Nov 22, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 22, 2019

Test PASSed.

Copy link
Member

jrudolph left a comment

LGTM with a small wording nitpick.

s"before materializing the dataBytes stream."
override def toString = {
s"EntityStreamSizeException: incoming entity size (${actualSize.getOrElse("while streaming")}) exceeded size limit ($limit bytes)! " +
"This may have been a parser maximum (set via `akka.http.[server|client].parsing.max-content-length`), " +

This comment has been minimized.

Copy link
@jrudolph

jrudolph Nov 25, 2019

Member

Maybe replace "maximum" with "limit"?

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 25, 2019

Test PASSed.

Copy link
Member

jrudolph left a comment

Thanks, LGTM.

@jrudolph jrudolph merged commit 671596c into master Nov 25, 2019
5 checks passed
5 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation 1089 tests run, 58 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph deleted the EntityStreamSizeExceptionMessage branch Nov 25, 2019
raboof added a commit that referenced this pull request Nov 27, 2019
Fixes #2827 by reflecting the change in #2823
@raboof raboof mentioned this pull request Nov 27, 2019
raboof added a commit that referenced this pull request Nov 27, 2019
Fixes #2827 by reflecting the change in #2823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.