Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone down the connection failure warning #2837

Merged
merged 1 commit into from Nov 28, 2019
Merged

Tone down the connection failure warning #2837

merged 1 commit into from Nov 28, 2019

Conversation

@huntc
Copy link
Contributor

huntc commented Nov 27, 2019

Failure is normal.

Fixes #2830

Failure is normal.
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 27, 2019

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

@raboof

This comment has been minimized.

Copy link
Member

raboof commented Nov 28, 2019

OK TO TEST

@akka-ci akka-ci added validating tested and removed validating labels Nov 28, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 28, 2019

Test PASSed.

@raboof
raboof approved these changes Nov 28, 2019
Copy link
Member

johanandren left a comment

LGTM

@johanandren johanandren merged commit fe7f5f5 into akka:master Nov 28, 2019
4 checks passed
4 checks passed
Jenkins PR Auto-Formatter Successful
Details
Jenkins PR Validation 4180 tests run, 1074 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@huntc huntc deleted the huntc:warning branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.