Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace abandoned swakka with actively maintained swagger-akka-http #4129

Merged
merged 2 commits into from Jun 7, 2022

Conversation

leviramsey
Copy link
Contributor

Swakka appears to be abandoned (no maintainer activity in 3 years) and there's an outstanding issue around 10.2.x support. Additionally, it's not built for Scala 2.13.

This PR proposes to recommend swagger-akka-http in its place, which is more actively maintained. Alternatively, we can decide to not endorse that extension, in which case I think there's an even weaker case for endorsing swakka.

@leviramsey leviramsey changed the title Update docs with new swagger extension docs: replace abandoned swakka with actively maintained swagger-akka-http Jun 3, 2022
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good point. swagger-akka-http looks useful enough to add in here.

@jrudolph jrudolph marked this pull request as ready for review June 7, 2022 13:50
@jrudolph jrudolph enabled auto-merge (squash) June 7, 2022 13:50
@jrudolph jrudolph added this to the 10.2.10 milestone Jun 7, 2022
@jrudolph jrudolph merged commit 294eb5d into akka:main Jun 7, 2022
@leviramsey leviramsey deleted the swagger branch June 7, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants