Add logging to remote watcher once heartbeat delays start to grow too large #17389

Closed
drewhk opened this Issue May 6, 2015 · 2 comments

Comments

Projects
None yet
4 participants
Member

drewhk commented May 6, 2015

We should start logging at WARN levels once heartbeat delays grow over a threshold (for example half of acceptable heartbeat pause)

drewhk added the 1 - triaged label May 6, 2015

drewhk added this to the 2.3.x milestone May 6, 2015

@patriknw patriknw modified the milestone: 2.4.x, 2.3.x Aug 26, 2015

patriknw added the t:remoting label Aug 26, 2015

rkuhn removed the 1 - triaged label Mar 9, 2016

Contributor

fadyZohdy commented Jun 2, 2017 edited

i started working on this task and from what i understand from the code this will be calculated in the failure detector with something like this and correct me if i am wrong

def isHeartbeatDelayed: Boolean = lastestInterval >= (acceptableHeartbeatPauseMillis / 2) 

so my question is should i just log the warning in the phaiAccrualDetector or should it be declared as a function in the FailureDetector trait and implemented in all the child classes and move the logging to the RemoteWatcher ?

Owner

patriknw commented Jun 9, 2017

It's probably easiest to impl the logging in the concrete failure detector, e.g. backwards compatibility.

@fadyZohdy fadyZohdy added a commit to fadyZohdy/akka that referenced this issue Jun 10, 2017

@fadyZohdy fadyZohdy add heartbeat delays warning log to remoteWatcer #17389 410d5d3

@patriknw patriknw added a commit that referenced this issue Jun 16, 2017

@fadyZohdy @patriknw fadyZohdy + patriknw add heartbeat delays warning log to remoteWatcer #17389 (#23135)
* add heartbeat delays warning log to remoteWatcer #17389

* using eventStream for logging

* add backward compatibility constructor

* make eventstream Option
398e3d0

@patriknw patriknw modified the milestone: 2.5.3, 2.4.x Jun 16, 2017

patriknw closed this Jun 16, 2017

@patriknw patriknw added a commit that referenced this issue Jun 16, 2017

@patriknw patriknw Merge pull request #23177 from akka/wip-17389-fix-PhiAccrualFailureDe…
…tector-constructor-patriknw

revert change of PhiAccrualFailureDetector constructor, #17389
b9ab33a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment