Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add logging to remote watcher once heartbeat delays start to grow too large #17389
Comments
drewhk
added the
1 - triaged
label
May 6, 2015
drewhk
added this to the
2.3.x
milestone
May 6, 2015
patriknw
modified the milestone: 2.4.x, 2.3.x
Aug 26, 2015
patriknw
added the
t:remoting
label
Aug 26, 2015
rkuhn
removed the
1 - triaged
label
Mar 9, 2016
patriknw
added easy-to-contribute 1 - triaged
labels
Mar 21, 2016
|
i started working on this task and from what i understand from the code this will be calculated in the failure detector with something like this and correct me if i am wrong def isHeartbeatDelayed: Boolean = lastestInterval >= (acceptableHeartbeatPauseMillis / 2) so my question is should i just log the warning in the phaiAccrualDetector or should it be declared as a function in the FailureDetector trait and implemented in all the child classes and move the logging to the RemoteWatcher ? |
|
It's probably easiest to impl the logging in the concrete failure detector, e.g. backwards compatibility. |
fadyZohdy
added a commit
to fadyZohdy/akka
that referenced
this issue
Jun 10, 2017
|
|
fadyZohdy |
410d5d3
|
johanandren
referenced
this issue
Jun 14, 2017
Merged
add heartbeat delays warning log to remoteWatcer #17389 #23135
patriknw
added a commit
that referenced
this issue
Jun 16, 2017
|
|
fadyZohdy + patriknw |
398e3d0
|
patriknw
modified the milestone: 2.5.3, 2.4.x
Jun 16, 2017
patriknw
closed this
Jun 16, 2017
patriknw
added a commit
that referenced
this issue
Jun 16, 2017
|
|
patriknw |
04883dc
|
patriknw
referenced
this issue
Jun 16, 2017
Closed
mima filter for PhiAccrualFailureDetector constructor, #17389 #23176
patriknw
added a commit
that referenced
this issue
Jun 16, 2017
|
|
patriknw |
e8aa702
|
patriknw
referenced
this issue
Jun 16, 2017
Merged
revert change of PhiAccrualFailureDetector constructor, #17389 #23177
patriknw
added a commit
that referenced
this issue
Jun 16, 2017
|
|
patriknw |
b9ab33a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
drewhk commentedMay 6, 2015
We should start logging at WARN levels once heartbeat delays grow over a threshold (for example half of acceptable heartbeat pause)