New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide Maven users how to configure concat for reference.conf instead of replace, in maven assembly #18813

Open
ktoso opened this Issue Oct 29, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@ktoso
Member

ktoso commented Oct 29, 2015

(Same applies to Gradle).

People doing fatjars, coming from java-land, end up sometimes getting config blow up since the default strategy of "2 names with the same name" is "replace" in those tools (Maven, Gradle), which does not make sense for reference.conf.

@ktoso ktoso added this to the 2.4.x milestone Oct 29, 2015

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Oct 29, 2015

Member

Note to self, maybe we add a better error message for setting not found as well?

Member

ktoso commented Oct 29, 2015

Note to self, maybe we add a better error message for setting not found as well?

@ktoso

This comment has been minimized.

Show comment
Hide comment
@viktorklang

This comment has been minimized.

Show comment
Hide comment
@viktorklang

viktorklang Oct 29, 2015

Member

even better—point to the reference docs for the version of akka it uses :)

Member

viktorklang commented Oct 29, 2015

even better—point to the reference docs for the version of akka it uses :)

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Oct 29, 2015

Member

Yes, though it does need a fallback (to current I'd say) - since the version is stored in reference.conf which is the file we may be failing because right now (i.e. persistence's reference overwrote actors' reference) 👍

Member

ktoso commented Oct 29, 2015

Yes, though it does need a fallback (to current I'd say) - since the version is stored in reference.conf which is the file we may be failing because right now (i.e. persistence's reference overwrote actors' reference) 👍

@viktorklang

This comment has been minimized.

Show comment
Hide comment
@viktorklang

viktorklang Oct 29, 2015

Member

@ktoso But you are wrong :) see ActorSystem.Version

Member

viktorklang commented Oct 29, 2015

@ktoso But you are wrong :) see ActorSystem.Version

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Oct 29, 2015

Member

Oh ok, I grepped but only noticed ConfigVersion, great so we can link to the right one.

Member

ktoso commented Oct 29, 2015

Oh ok, I grepped but only noticed ConfigVersion, great so we can link to the right one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment