Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed: FlowSplitWhenSpec #22097

Closed
patriknw opened this issue Jan 3, 2017 · 3 comments
Closed

failed: FlowSplitWhenSpec #22097

patriknw opened this issue Jan 3, 2017 · 3 comments
Labels
3 - in progress Someone is working on this ticket failed Tickets that indicate a CI failure, likely a flakey test t:stream
Milestone

Comments

@patriknw
Copy link
Member

patriknw commented Jan 3, 2017

https://jenkins.akka.io:8498/job/pr-validator-per-commit-jenkins/8118

[info] - must fail substream if materialized twice *** FAILED *** (2 seconds, 40 milliseconds)
[info]   Expected exception java.lang.IllegalStateException to be thrown, but no exception was thrown (FlowSplitWhenSpec.scala:260)
[info]   org.scalatest.exceptions.TestFailedException:
[info]   at org.scalatest.MatchersHelper$.indicateFailure(MatchersHelper.scala:340)
[info]   at org.scalatest.words.ResultOfAnTypeInvocation.mustBe(ResultOfAnTypeInvocation.scala:155)
[info]   at akka.stream.scaladsl.FlowSplitWhenSpec$$anonfun$2$$anonfun$apply$mcV$sp$14$$anonfun$apply$18.apply(FlowSplitWhenSpec.scala:260)
[info]   at akka.stream.scaladsl.FlowSplitWhenSpec$$anonfun$2$$anonfun$apply$mcV$sp$14$$anonfun$apply$18.apply(FlowSplitWhenSpec.scala:260)
[info]   at akka.stream.testkit.Utils$.assertAllStagesStopped(Utils.scala:25)
[info]   at akka.stream.scaladsl.FlowSplitWhenSpec$$anonfun$2$$anonfun$apply$mcV$sp$14.apply(FlowSplitWhenSpec.scala:259)
[info]   at akka.stream.scaladsl.FlowSplitWhenSpec$$anonfun$2$$anonfun$apply$mcV$sp$14.apply(FlowSplitWhenSpec.scala:259)
@patriknw patriknw added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted failed Tickets that indicate a CI failure, likely a flakey test t:stream labels Jan 3, 2017
@ktoso
Copy link
Member

ktoso commented Jan 3, 2017

Very weird one, should look into it soon. Splitting is used all over the place in http.

@ktoso ktoso added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Jan 3, 2017
@drewhk drewhk added 3 - in progress Someone is working on this ticket and removed 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding labels Feb 7, 2017
@drewhk drewhk self-assigned this Feb 7, 2017
@drewhk
Copy link
Member

drewhk commented Feb 7, 2017

Seems like a race condition to me:

.mapAsync(1) { src  src.runWith(Sink.ignore); src.runWith(Sink.ignore) }

The above snippets assumes that the second will materialize to a failed future, but in practice there might be a race so there is a chance that the second runWith is the one that actually succeeds while the first fails. Since the first Future is ignored it will not show up if it fails. At least this is my hypothesis.

@2m
Copy link
Member

2m commented May 15, 2017

Fixed in #22266

@2m 2m closed this as completed May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - in progress Someone is working on this ticket failed Tickets that indicate a CI failure, likely a flakey test t:stream
Projects
None yet
Development

No branches or pull requests

4 participants