Incorrect view of initial contact points when subscribing to cluster client #22991

Closed
huntc opened this Issue May 22, 2017 · 0 comments

Comments

Projects
None yet
3 participants
Contributor

huntc commented May 22, 2017

Akka cluster client does not provide the correct initial view of contact points w.r.t. to another actor subscribing to its events. This is accidental and due to a previous PR by me where the ability to subscribe to notifications was provided. There is a variable named contactPathsPublished which is empty on startup. I see now that contactPathsPublished's initial value should be that of contactPaths, otherwise a subscriber will receive any initial contact points from config, and then ContactPointAdded messages for events regardless of whether they in the initial contact points.

By initialising contactPathsPublished with contactPaths then subsequent contact point notifications will yield ContactPointRemoved for those contact points that are unknown to the cluster client. I see this as being the correct behaviour, and have tested it by copying ClusterClient into ConductR.

johanandren closed this in #22992 Jun 4, 2017

@johanandren johanandren added a commit that referenced this issue Jun 4, 2017

@huntc @johanandren huntc + johanandren Corrected the setup of contact paths for subscribers #22991
The initial contact paths should be assumed as published as that's what client subscribers will receive upon subscription. Any changes to contact points are a delta to that.
f4bf497

johanandren reopened this Jun 4, 2017

johanandren added this to the 2.4.19 milestone Jun 4, 2017

@fadyZohdy fadyZohdy added a commit to fadyZohdy/akka that referenced this issue Jun 4, 2017

@huntc @fadyZohdy huntc + fadyZohdy Corrected the setup of contact paths for subscribers #22991
The initial contact paths should be assumed as published as that's what client subscribers will receive upon subscription. Any changes to contact points are a delta to that.
208b6c3

patriknw closed this Jun 7, 2017

@patriknw patriknw added a commit that referenced this issue Jun 12, 2017

@huntc @patriknw huntc + patriknw Corrected the setup of contact paths for subscribers #22991
The initial contact paths should be assumed as published as that's what client subscribers will receive upon subscription. Any changes to contact points are a delta to that.
178c811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment