New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubSourceOutlet push should fail eagerly #23929

Closed
jrudolph opened this Issue Nov 6, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@jrudolph
Member

jrudolph commented Nov 6, 2017

As observed in akka/akka-http#1515, calling outlet.push will not fail directly but only later when the push is processed on the other side of the async boundary. On that side the error message has lost any context.

Afaics the fix might be as simple as checking available before pushing here:

@ktoso ktoso added 3 - in progress and removed 1 - triaged labels Dec 4, 2017

@ktoso ktoso added this to the 2.5.8 milestone Dec 4, 2017

@ktoso ktoso closed this in #24083 Dec 5, 2017

ktoso added a commit that referenced this issue Dec 5, 2017

=str #23929 Fix double push message in sub source (#24083)
* Fix double push message in sub source

* Add name of pushed port in failure message

* Update GraphStageLogicSpec.scala

* Change substreamEmit to SubstreamEmit

manonthegithub added a commit to manonthegithub/akka that referenced this issue Jan 31, 2018

=str akka#23929 Fix double push message in sub source (akka#24083)
* Fix double push message in sub source

* Add name of pushed port in failure message

* Update GraphStageLogicSpec.scala

* Change substreamEmit to SubstreamEmit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment