New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide top-level serializer for Address #24265

Closed
ktoso opened this Issue Jan 8, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@ktoso
Member

ktoso commented Jan 8, 2018

While we do serialize Address to protobuf, we always to this by extracting the Address from some envelope, be it Heartbeat etc.

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Jan 8, 2018

Member

and UniqueAddress while I'm at it

Member

ktoso commented Jan 8, 2018

and UniqueAddress while I'm at it

ktoso added a commit to ktoso/akka that referenced this issue Jan 8, 2018

ktoso added a commit to ktoso/akka that referenced this issue Jan 8, 2018

@ktoso ktoso closed this in #24267 Jan 10, 2018

ktoso added a commit that referenced this issue Jan 10, 2018

+rem #24265 protobuf serializer for Address and UniqueAddress in akka… (
#24267)

* +rem #24265 protobuf serializer for Address and UniqueAddress in akka-remote

* remove the duplication, by using previously existing type

* fixed doc link

* make it easier to enable the additional no-java-serialization bindings

* fixed akka-actor failure due to changes

* cleanup

* Update reference.conf

* Update serialization.md

* Update reference.conf

@patriknw patriknw added this to the 2.5.9 milestone Jan 11, 2018

manonthegithub added a commit to manonthegithub/akka that referenced this issue Jan 31, 2018

+rem akka#24265 protobuf serializer for Address and UniqueAddress in …
…akka… (akka#24267)

* +rem akka#24265 protobuf serializer for Address and UniqueAddress in akka-remote

* remove the duplication, by using previously existing type

* fixed doc link

* make it easier to enable the additional no-java-serialization bindings

* fixed akka-actor failure due to changes

* cleanup

* Update reference.conf

* Update serialization.md

* Update reference.conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment