New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expectNoMessage should consume the message from the queue #24270

Closed
ktoso opened this Issue Jan 9, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@ktoso
Member

ktoso commented Jan 9, 2018

In the recent PR dfd94d3 the implementation was changes such that it dopes not consume the not-expected-message.

I think this was rather accidental so fixing it.

The peek + sleep is fine, though we also should pop after that.

Refs #23224 which was the rewrite

@ktoso ktoso self-assigned this Jan 9, 2018

@ktoso ktoso added this to the 2.5.9 milestone Jan 9, 2018

ktoso added a commit to ktoso/akka that referenced this issue Jan 9, 2018

@johanandren

This comment has been minimized.

Show comment
Hide comment
@johanandren

johanandren Jan 9, 2018

Member

Hmm, does it matter, when it will fail the test anyway?

Member

johanandren commented Jan 9, 2018

Hmm, does it matter, when it will fail the test anyway?

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Jan 9, 2018

Member

I think it was an unintended change in semantics.
Use cases is a bit weird but reasonable, see [akka-user] expectNoMessage keeps unexpected message in the queue

Member

ktoso commented Jan 9, 2018

I think it was an unintended change in semantics.
Use cases is a bit weird but reasonable, see [akka-user] expectNoMessage keeps unexpected message in the queue

@johanandren

This comment has been minimized.

Show comment
Hide comment
@johanandren
Member

johanandren commented Jan 9, 2018

@ktoso

This comment has been minimized.

Show comment
Hide comment
@ktoso

ktoso Jan 9, 2018

Member

Sorry for lack of direct link :)

Member

ktoso commented Jan 9, 2018

Sorry for lack of direct link :)

ktoso added a commit to ktoso/akka that referenced this issue Jan 9, 2018

@ktoso ktoso closed this in #24271 Jan 9, 2018

ktoso added a commit that referenced this issue Jan 9, 2018

=tes #24270 expectNoMessage should pull the unexpected msg (#24271)
* =tes #24270 expectNoMessage should pull the unexpected msg from the queue

* Update TestKit.scala

@ktoso ktoso removed the 3 - in progress label Jan 9, 2018

manonthegithub added a commit to manonthegithub/akka that referenced this issue Jan 31, 2018

=tes akka#24270 expectNoMessage should pull the unexpected msg (akka#…
…24271)

* =tes akka#24270 expectNoMessage should pull the unexpected msg from the queue

* Update TestKit.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment