New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ActorContext parameter in scaladsl command handlers #25620

Closed
patriknw opened this Issue Sep 14, 2018 · 1 comment

Comments

@patriknw
Member

patriknw commented Sep 14, 2018

Independent of the outcome of other discussions such as the enclosing class we should remove the ActorContext parameter from command handler signatures.

Reasons:

  • The type signature become less monstrous
  • Cleaner when pure domain modeling is preferred (ActorContext not needed)
  • Can easily be included in scope via Behaviors.setup when needed
@patriknw

This comment has been minimized.

Show comment
Hide comment
@patriknw

patriknw Sep 14, 2018

Member

Note that this is already done for javadsl

Member

patriknw commented Sep 14, 2018

Note that this is already done for javadsl

@patriknw patriknw added this to Backlog in Akka Typed Sep 14, 2018

@patriknw patriknw moved this from Backlog to In Progress in Akka Typed Sep 20, 2018

johanandren added a commit to johanandren/akka that referenced this issue Sep 20, 2018

@johanandren johanandren moved this from In Progress to Reviewing in Akka Typed Sep 21, 2018

@johanandren johanandren added this to the 2.5.17 milestone Sep 21, 2018

@johanandren johanandren moved this from Reviewing to Done in Akka Typed Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment