New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic stop message for Typed Sharding #25642

Closed
patriknw opened this Issue Sep 19, 2018 · 1 comment

Comments

1 participant
@patriknw
Member

patriknw commented Sep 19, 2018

Sharding requires definition of a stopMessage that is sent to the actor when rebalanced or passivated.

This doesn't exist in Lagom and may be seen as a technical concern that is blurring the business logic in the entity. Would be nice to make it optional, but it would mean implementing something like a PoisonPill (handled by Akka and not user code) that also worked with persistent actors.

This is broken out from #25480

@patriknw

This comment has been minimized.

Member

patriknw commented Sep 21, 2018

Similar could be used for Singleton #25642

@patriknw patriknw added 3 - in progress and removed discuss labels Oct 22, 2018

@patriknw patriknw self-assigned this Oct 22, 2018

patriknw added a commit that referenced this issue Oct 22, 2018

Make the stop message in sharding optional, #25642
* It's mostly technical concern that is blurring the business logic in the entity
* Async interactions before stopping is often not needed
* Implemented with an internal PoisonPill signal that is added by sharding,
* Persistent actors handle PoisonPill and run side effects after persist
  and process stashed messages before stopping.

@patriknw patriknw moved this from Backlog to In Progress in Akka Typed Oct 23, 2018

patriknw added a commit that referenced this issue Nov 5, 2018

Make the stop message in sharding optional, #25642
* It's mostly technical concern that is blurring the business logic in the entity
* Async interactions before stopping is often not needed
* Implemented with an internal PoisonPill signal that is added by sharding,
* Persistent actors handle PoisonPill and run side effects after persist
  and process stashed messages before stopping.

patriknw added a commit that referenced this issue Nov 5, 2018

Make the stop message in sharding optional, #25642
* It's mostly technical concern that is blurring the business logic in the entity
* Async interactions before stopping is often not needed
* Implemented with an internal PoisonPill signal that is added by sharding,
* Persistent actors handle PoisonPill and run side effects after persist
  and process stashed messages before stopping.

patriknw added a commit that referenced this issue Nov 5, 2018

Make the stop message in sharding optional, #25642
* It's mostly technical concern that is blurring the business logic in the entity
* Async interactions before stopping is often not needed
* Implemented with an internal PoisonPill signal that is added by sharding,
* Persistent actors handle PoisonPill and run side effects after persist
  and process stashed messages before stopping.

* remove unecessary stop messages

* reference docs

patriknw added a commit that referenced this issue Nov 6, 2018

Make the stop message in sharding optional, #25642
* It's mostly technical concern that is blurring the business logic in the entity
* Async interactions before stopping is often not needed
* Implemented with an internal PoisonPill signal that is added by sharding,
* Persistent actors handle PoisonPill and run side effects after persist
  and process stashed messages before stopping.

* remove unecessary stop messages

* reference docs

patriknw added a commit that referenced this issue Nov 6, 2018

Make the stop message in sharding optional, #25642
* It's mostly technical concern that is blurring the business logic in the entity
* Async interactions before stopping is often not needed
* Implemented with an internal PoisonPill signal that is added by sharding,
* Persistent actors handle PoisonPill and run side effects after persist
  and process stashed messages before stopping.

* remove unecessary stop messages

* reference docs

patriknw added a commit that referenced this issue Nov 6, 2018

Merge pull request #25818 from akka/wip-25642-auto-sharding-stop-msg-…
…patriknw

Make the stop message in sharding optional, #25642

@patriknw patriknw added this to the 2.5.18 milestone Nov 6, 2018

@patriknw patriknw closed this Nov 6, 2018

@patriknw patriknw moved this from In Progress to Done in Akka Typed Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment