Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ActorSystem.whenTerminated to `Future[Done]` in Typed #25647

Closed
patriknw opened this Issue Sep 20, 2018 · 0 comments

Comments

Projects
2 participants
@patriknw
Copy link
Member

commented Sep 20, 2018

The Future[Terminated] was probably carried over from Untyped. The only purpose I can see of using Terminated would be to expose the exception in the guardian causing the termination, if any.

As can be seen in the attempt in #25352 it's complicated to implement and has questionable value (see discussion in that PR).

Let's simplify and use Done.

@patriknw patriknw added this to Backlog in Akka Typed Sep 20, 2018

tz70s added a commit to tz70s/akka that referenced this issue Sep 20, 2018

Change typed whenTerminated sig to Future[Done].
This change ignore the terminated passed from untyped map it into Done.
Resolve akka#25647.

tz70s added a commit to tz70s/akka that referenced this issue Sep 20, 2018

Change typed whenTerminated sig to Future[Done].
This change ignore the terminated passed from untyped map it into Done.
Resolve akka#25647.

tz70s added a commit to tz70s/akka that referenced this issue Sep 20, 2018

Change typed whenTerminated sig to Future[Done].
This change ignore the terminated passed from untyped and map it into Done.
Resolve akka#25647.

tz70s added a commit to tz70s/akka that referenced this issue Sep 20, 2018

Change typed whenTerminated sig to Future[Done].
This change ignore the terminated passed from untyped and map it into Done.
Resolve akka#25647.

@johanandren johanandren moved this from Backlog to In Progress in Akka Typed Sep 21, 2018

@johanandren johanandren moved this from In Progress to Reviewing in Akka Typed Sep 21, 2018

tz70s added a commit to tz70s/akka that referenced this issue Dec 11, 2018

Change typed whenTerminated sig to Future[Done].
This change ignore the terminated passed from untyped and map it into Done.

Resolve akka#25647.

tz70s added a commit to tz70s/akka that referenced this issue Dec 11, 2018

Change typed whenTerminated sig to Future[Done].
This change ignore the terminated passed from untyped and map it into Done,
with some minor changes for testing termination.

Resolve akka#25647.

tz70s added a commit to tz70s/akka that referenced this issue Mar 1, 2019

Change typed whenTerminated sig to Future[Done].
This change ignore the terminated passed from untyped and map it into Done,
with some minor changes for testing termination.

Resolve akka#25647.

tz70s added a commit to tz70s/akka that referenced this issue Mar 1, 2019

Change typed whenTerminated sig to Future[Done].
This change ignore the terminated passed from untyped and map it into Done,
with some minor changes for testing termination.

Resolve akka#25647.

@patriknw patriknw added this to the 2.5.22 milestone Mar 31, 2019

patriknw added a commit that referenced this issue Apr 1, 2019

Change typed whenTerminated sig to Future[Done].
This change ignore the terminated passed from untyped and map it into Done,
with some minor changes for testing termination.

Resolve #25647.

patriknw added a commit that referenced this issue Apr 1, 2019

Change typed whenTerminated signature to Future[Done], #25647
This change ignore the terminated passed from untyped and map it into Done,
with some minor changes for testing termination.

termiate() returns Unit to not bias it towards the Scala API, completion
can be observed with whenTerminated or getWhenTerminated

patriknw added a commit that referenced this issue Apr 1, 2019

Change typed whenTerminated signature to Future[Done], #25647
This change ignore the terminated passed from untyped and map it into Done,
with some minor changes for testing termination.

termiate() returns Unit to not bias it towards the Scala API, completion
can be observed with whenTerminated or getWhenTerminated

patriknw added a commit that referenced this issue Apr 1, 2019

Merge pull request #26644 from akka/wip-whenTerminate-patriknw
Change typed whenTerminated sig to Future[Done], #25647

@patriknw patriknw closed this Apr 1, 2019

Akka Typed automation moved this from Reviewing to Done Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.