New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ClusterSharding.start to init in Typed #25711

Closed
patriknw opened this Issue Oct 1, 2018 · 4 comments

Comments

4 participants
@patriknw
Member

patriknw commented Oct 1, 2018

Some uncertainties about what start means. What is started?

init is good since it conveys that it's something that should be done once early when the system is started up

@hepin1989

This comment has been minimized.

Contributor

hepin1989 commented Oct 1, 2018

Yes,it should be initializating and initialized.

@patriknw patriknw added this to Backlog in Akka Typed Oct 15, 2018

@patriknw patriknw added 3 - in progress and removed 1 - triaged labels Nov 5, 2018

@patriknw patriknw self-assigned this Nov 5, 2018

patriknw added a commit that referenced this issue Nov 5, 2018

patriknw added a commit that referenced this issue Nov 5, 2018

chbatey added a commit that referenced this issue Nov 5, 2018

rename ClusterSharding start to init, #25711 (#25867)
* rename ClusterSharding start to init, #25711

* fix test

@chbatey chbatey added this to the 2.5.18 milestone Nov 5, 2018

patriknw added a commit that referenced this issue Nov 5, 2018

rename ClusterSharding start to init, #25711 (#25867)
* rename ClusterSharding start to init, #25711

* fix test
@dwijnand

This comment has been minimized.

Member

dwijnand commented Nov 6, 2018

Fixed in #25867.

patriknw added a commit that referenced this issue Nov 6, 2018

rename ClusterSharding start to init, #25711 (#25867)
* rename ClusterSharding start to init, #25711

* fix test

patriknw added a commit that referenced this issue Nov 6, 2018

rename ClusterSharding start to init, #25711 (#25867)
* rename ClusterSharding start to init, #25711

* fix test

@patriknw patriknw closed this Nov 6, 2018

@dwijnand

This comment has been minimized.

Member

dwijnand commented Nov 6, 2018

Oh right, that didn't target master.

While I'm here, is there a reason you don't use the "Fixes #25711" to auto-close PRs? https://help.github.com/articles/closing-issues-using-keywords/

@patriknw

This comment has been minimized.

Member

patriknw commented Nov 7, 2018

@dwijnand it's perfectly ok to use Fixes but then you have to anyway check that the issue has the right milestone assigned (since we use the milestones for our release notes)

@patriknw patriknw moved this from Backlog to Done in Akka Typed Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment