New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support null as emptyState #25768

Closed
patriknw opened this Issue Oct 10, 2018 · 2 comments

Comments

1 participant
@patriknw
Member

patriknw commented Oct 10, 2018

Java has always been, and still is, pragmatic about using null and I think a valid alternative for Java is to support null as empty state.

@patriknw

This comment has been minimized.

Member

patriknw commented Oct 10, 2018

When doing this, also look into why we have State >: Null as the type parameter

@patriknw patriknw added this to Backlog in Akka Typed Oct 15, 2018

@patriknw patriknw self-assigned this Oct 17, 2018

@patriknw patriknw moved this from Backlog to In Progress in Akka Typed Oct 17, 2018

@patriknw

This comment has been minimized.

Member

patriknw commented Oct 17, 2018

The State >: Null comes from an OptionVal in the builder. Let's revise that when adjusting the builders.

patriknw added a commit that referenced this issue Oct 18, 2018

@patriknw patriknw added this to the 2.5.18 milestone Oct 19, 2018

@patriknw patriknw closed this Oct 19, 2018

@patriknw patriknw moved this from In Progress to Done in Akka Typed Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment