New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharding forgets remembered entities with change in sharding funcion #25809

Closed
zbynek001 opened this Issue Oct 18, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@zbynek001
Copy link

zbynek001 commented Oct 18, 2018

When you have sharding with remembered entities and you change sharding function when cluster is not running. What happens with entities, that should now go to different shard? It looks like those will start, but will be forgotten.

The original shard will remove the information about an entity here:

processChange(EntityStopped(ack.entityId)) { _

And the new shard will just start it:

but will not remember it via EntityStarted

Or am I missing something?

@patriknw

This comment has been minimized.

Copy link
Member

patriknw commented Oct 22, 2018

@zbynek001 Good observation. I think you are right. Looks like it's only stored when started via deliverTo (and a few more cases).

Would you be able to create a PR fixing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment