New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster event listener that logs all events #25832

Closed
patriknw opened this Issue Oct 27, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@patriknw
Copy link
Member

patriknw commented Oct 27, 2018

Would be useful when troubleshooting to be able to enable more verbose logging of all cluster events.

Perhaps even something we should make possible to turn on/off in runtime, and provide action of it in Akka Management.

@patriknw

This comment has been minimized.

Copy link
Member

patriknw commented Nov 12, 2018

  • Logging can be added to ClusterReadView
  • It should be at INFO level, but enabled via config property, we already have akka.cluster.log-info so perhaps this one should be akka.cluster.log-verbose-info? disabled by default
  • The log messages should follow the same format as other cluster logging, i.e. prefixed with "Cluster Node"

@helena helena self-assigned this Nov 12, 2018

@helena

This comment has been minimized.

Copy link
Member

helena commented Nov 12, 2018

@patriknw Some thoughts for feedback:

  1. +1 disabled by default, opt-in
  2. I imagine, given the potential load, it would need its own dispatcher
  3. akka.cluster.log-info-verbose ('info' seems implicit/redundant however given this is an extension of the existing behavior, keeping the naming convention makes sense)
@patriknw

This comment has been minimized.

Copy link
Member

patriknw commented Nov 12, 2018

I imagine, given the potential load, it would need its own dispatcher

I don't think it will be much load, actually. It's only when the membership changes and when unreachability.

Note my suggestion to add it to the existing actor that is already listening to most of these events: https://github.com/akka/akka/blob/master/akka-cluster/src/main/scala/akka/cluster/ClusterReadView.scala#L55
In that way we don't generate more actor messages, but only some additional logging.

I think we should skip logging of SeenChanged, because that is not very interesting and happens frequently.

@patriknw

This comment has been minimized.

Copy link
Member

patriknw commented Nov 13, 2018

When starting working on an issue you can also select the label "in progress".

helena added a commit to helena/akka that referenced this issue Nov 14, 2018

helena added a commit to helena/akka that referenced this issue Nov 14, 2018

helena added a commit to helena/akka that referenced this issue Nov 14, 2018

patriknw added a commit that referenced this issue Nov 15, 2018

@patriknw patriknw added this to the 2.5.19 milestone Nov 15, 2018

@patriknw patriknw closed this Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment