New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge PatternsCS into Patterns for Java API? #26000

Closed
hepin1989 opened this Issue Nov 29, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@hepin1989
Copy link
Contributor

hepin1989 commented Nov 29, 2018

I think this is worth to do.with the leverage of Duration etc thing ,it's easy to distinct the API for Scala or Java.
PatternsCS is not much findable.

or ,in 2.6 we could do akka.patten.javadsl.Patterns and akka.patten.scaladsl.Patterns like thing.
refs:#22316

@patriknw

This comment has been minimized.

Copy link
Member

patriknw commented Nov 29, 2018

I agree, with the java.time.Duration distinction it's possible.

@hepin1989

This comment has been minimized.

Copy link
Contributor

hepin1989 commented Nov 29, 2018

There is no way to handle these kind of:)

  def ask(selection: ActorSelection, message: Any, timeoutMillis: Long): CompletionStage[AnyRef]
@hepin1989

This comment has been minimized.

Copy link
Contributor

hepin1989 commented Nov 29, 2018

if that could be done,then seems like all PatternsCS could go,and then just deprecated it and update the document.

@hepin1989

This comment has been minimized.

Copy link
Contributor

hepin1989 commented Nov 30, 2018

As #26015 just did, I think it would be the best move to merge both Scala API and Java API when we are not using time:Long,timeUnit:TimeUnit like thing in the API.

@patriknw patriknw added this to the 2.5.19 milestone Dec 6, 2018

@patriknw patriknw closed this Dec 6, 2018

patriknw added a commit that referenced this issue Dec 6, 2018

patriknw added a commit that referenced this issue Dec 6, 2018

@patriknw patriknw referenced this issue Dec 7, 2018

Merged

Akka 2.5.19 #534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment