Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed Persistence: Replace SnapshotSelectionCriteria #26536

Closed
helena opened this Issue Mar 14, 2019 · 1 comment

Comments

Projects
2 participants
@helena
Copy link
Member

commented Mar 14, 2019

Initial discussion in: Typed Persistence: Implement deleting snapshots / events #24698

@patriknw

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

It's only SnapshotSelectionCriteria and SnapshotMetadata that we expose from untyped persistence in typed user APIs. To make the typed APIs independent of untyped persistence I think we should do this (and it's a low effort).

SnapshotMetadata too.

To find this I used:

find akka-persistence-typed/src/main/scala/akka/persistence/typed/ -name "*.scala" | xargs grep "akka.persistence" | grep -v "internal/" |  grep -v "akka\.persistence\.typed" | grep -v "SnapshotProtocol" | grep -v "JournalProtocol"

@patriknw patriknw added this to Ready for production backlog in Akka Typed Mar 15, 2019

@helena helena moved this from Ready for production backlog to Backlog in Akka Typed Mar 16, 2019

@patriknw patriknw moved this from Backlog to Ready for production backlog in Akka Typed Mar 19, 2019

@patriknw patriknw moved this from Ready for production backlog to In Progress in Akka Typed Mar 22, 2019

@patriknw patriknw self-assigned this Mar 22, 2019

patriknw added a commit that referenced this issue Mar 22, 2019

Replace SnapshotSelectionCriteria and SnapshotMetadata, #26536
* This may look like a duplicating the existing classes from untyped
  persistence without any value, but those two classes were there only
  two from untyped that were exposed in end user APIs.
* This makes the API independent of untyped.
* Those classes can be evolved (much) easier since they are not case classes.

patriknw added a commit that referenced this issue Mar 22, 2019

Replace SnapshotSelectionCriteria and SnapshotMetadata, #26536
* This may look like a duplicating the existing classes from untyped
  persistence without any value, but those two classes were there only
  two from untyped that were exposed in end user APIs.
* This makes the API independent of untyped.
* Those classes can be evolved (much) easier since they are not case classes.

helena added a commit that referenced this issue Mar 22, 2019

Replace SnapshotSelectionCriteria and SnapshotMetadata, #26536 (#26596)
* This may look like a duplicating the existing classes from untyped
  persistence without any value, but those two classes were there only
  two from untyped that were exposed in end user APIs.
* This makes the API independent of untyped.
* Those classes can be evolved (much) easier since they are not case classes.

@patriknw patriknw closed this Mar 26, 2019

Akka Typed automation moved this from In Progress to Done Mar 26, 2019

@patriknw patriknw added this to the 2.5.22 milestone Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.