Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of DDataShard stashing #26877

Closed
patriknw opened this issue May 7, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@patriknw
Copy link
Member

commented May 7, 2019

It's performing the updates to remembering entities state one by one and stashing all other messages while waiting for the update to complete.

It should at least be possible on messages for other already started entities.

@patriknw patriknw self-assigned this May 7, 2019

@patriknw patriknw added 3 - in progress and removed 1 - triaged labels May 7, 2019

patriknw added a commit that referenced this issue May 7, 2019

Improve performance of DDataShard stashing, #26877
* While waiting for update to comple it will now deliver messages to other
  already started entities immediately, instead of stashing
* Unstash one message at a time, instead of unstashAll
* Append messageBuffer for messages to the entity that we are waiting for,
  instead of stashing
* Test to confirm the improvements

patriknw added a commit that referenced this issue May 7, 2019

Improve performance of DDataShard stashing, #26877
* While waiting for update to comple it will now deliver messages to other
  already started entities immediately, instead of stashing
* Unstash one message at a time, instead of unstashAll
* Append messageBuffer for messages to the entity that we are waiting for,
  instead of stashing
* Test to confirm the improvements
* Fixing a few other missing things
  * receiveStartEntity should process the change before starting the entity
  * lastMessageTimestamp should be touched from overridden deliverTo
  * handle StoreFailure

patriknw added a commit that referenced this issue May 7, 2019

Improve performance of DDataShard stashing, #26877
* While waiting for update to comple it will now deliver messages to other
  already started entities immediately, instead of stashing
* Unstash one message at a time, instead of unstashAll
* Append messageBuffer for messages to the entity that we are waiting for,
  instead of stashing
* Test to confirm the improvements
* Fixing a few other missing things
  * receiveStartEntity should process the change before starting the entity
  * lastMessageTimestamp should be touched from overridden deliverTo
  * handle StoreFailure

(cherry picked from commit 36e91fc)

patriknw added a commit that referenced this issue May 16, 2019

Improve performance of DDataShard stashing, #26877
* While waiting for update to comple it will now deliver messages to other
  already started entities immediately, instead of stashing
* Unstash one message at a time, instead of unstashAll
* Append messageBuffer for messages to the entity that we are waiting for,
  instead of stashing
* Test to confirm the improvements
* Fixing a few other missing things
  * receiveStartEntity should process the change before starting the entity
  * lastMessageTimestamp should be touched from overridden deliverTo
  * handle StoreFailure

patriknw added a commit that referenced this issue May 16, 2019

Merge pull request #26878 from akka/wip-optimize-DDShard-patriknw
Improve performance of DDataShard stashing, #26877

patriknw added a commit that referenced this issue May 16, 2019

Improve performance of DDataShard stashing, #26877
* While waiting for update to comple it will now deliver messages to other
  already started entities immediately, instead of stashing
* Unstash one message at a time, instead of unstashAll
* Append messageBuffer for messages to the entity that we are waiting for,
  instead of stashing
* Test to confirm the improvements
* Fixing a few other missing things
  * receiveStartEntity should process the change before starting the entity
  * lastMessageTimestamp should be touched from overridden deliverTo
  * handle StoreFailure

(cherry picked from commit ce43863)

@patriknw patriknw added this to the 2.5.23 milestone May 16, 2019

patriknw added a commit that referenced this issue May 16, 2019

Merge pull request #26940 from akka/wip-26877-backport-patriknw
Improve performance of DDataShard stashing, #26877

@patriknw patriknw closed this May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.