Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javadsl.FlowWithContext does not take another FlowWithContext in via #26896

Closed
2m opened this issue May 9, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@2m
Copy link
Member

commented May 9, 2019

The javadsl.FlowWithContext gets its stream shape from the delegate, which is a scaladsl.FlowWithContext, which in turn has FlowShape[(In, CtxIn), (Out, CtxOut)] shape.

Therefore the via method on javadsl.FlowWithContext that takes Graph[FlowShape[Pair[...]]] does not work.

Failing testcase: 2m@581dd20

This could be fixed by either:

  • changing the javadsl.FlowWithContext shape to have Pairs instead of tuples. However that needs reimplementation of quite a few javadsl.FlowWithContext
  • changing the via on javadsl.FlowWithContext take tuples instead. However scala types leaking out to the javadsl is not optimal.

@johanandren johanandren self-assigned this May 13, 2019

johanandren added a commit to johanandren/akka that referenced this issue May 13, 2019

johanandren added a commit to johanandren/akka that referenced this issue May 14, 2019

johanandren added a commit that referenced this issue May 15, 2019

@johanandren johanandren reopened this May 15, 2019

@johanandren johanandren added this to the 2.5.23 milestone May 15, 2019

johanandren added a commit to johanandren/akka that referenced this issue May 15, 2019

johanandren added a commit that referenced this issue May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.