Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please bump scalatest to 3.1.0 #28289

Closed
t3hnar opened this issue Dec 2, 2019 · 10 comments
Closed

Please bump scalatest to 3.1.0 #28289

t3hnar opened this issue Dec 2, 2019 · 10 comments

Comments

@t3hnar
Copy link
Contributor

@t3hnar t3hnar commented Dec 2, 2019

I've upgraded scalatest from 3.0.8 to 3.1.0 and start getting java.lang.NoClassDefFoundError: org/scalatest/WordSpecLike
It was traced down to PluginSpec in akka-persistence-tck

Could you please bump scalatest to 3.1.0 in akka in order to unblock all dependent projects.
Thanks.

@johanandren

This comment has been minimized.

Copy link
Member

@johanandren johanandren commented Dec 2, 2019

So, is WordSpecLike removed in 3.1.0? Looks like we use it in more places than that so it would be more work than just a dependency bump.

As a workaround you should be able to skip PluginSpec and use akka.testkit.TestKitBase yourself with some minimal glue.

@patriknw

This comment has been minimized.

Copy link
Member

@patriknw patriknw commented Dec 2, 2019

PluginSpec is part of the akka-persistence-tck, for example via JournalSpec so I think it's a valid request.

@patriknw

This comment has been minimized.

Copy link
Member

@patriknw patriknw commented Dec 2, 2019

@raboof

This comment has been minimized.

Copy link
Member

@raboof raboof commented Dec 2, 2019

So since scalatest did not keep binary compatibility we have the choice between forcing users to stay on 3.0.x or forcing users to update to 3.1.x .

Indeed since this only affects the testkit/tck projects it seems 👍 to move to 3.1.x

service-platform-operations-2 pushed a commit to hmrc/catalogue-frontend that referenced this issue Dec 23, 2019
@limansky

This comment has been minimized.

Copy link
Contributor

@limansky limansky commented Jan 7, 2020

Hi, I tried to use Scalafix as proposed in ScalaTest migration guide, was not able to add it to the project without changes in the build. Is there any good reason to use such old sbt version? Would it be ok, if I try to migrate to the latest sbt-0.13.x (I suppose this must be easier) or sbt-1.x in scope of this issue?

@johanandren

This comment has been minimized.

Copy link
Member

@johanandren johanandren commented Jan 8, 2020

@limansky Not sure if this relates to this issue? Akka is on sbt 1.3

@raboof

This comment has been minimized.

Copy link
Member

@raboof raboof commented Jan 8, 2020

#26989 can serve as some inspiration (though it probably has too many merge conflicts to be useful code-wise)

@limansky

This comment has been minimized.

Copy link
Contributor

@limansky limansky commented Jan 8, 2020

@johanandren oh, stupid me. I didn't realized that I already had a fork and it was pretty old.

@limansky

This comment has been minimized.

Copy link
Contributor

@limansky limansky commented Jan 11, 2020

Hi! I've created pull request on master, but possible it also have to be ported to version 2.5.x and to akka-http. I'm not really sure about that. Th problem is that it is binary incompatible, so, for example, it fails MiMa check.

@patriknw patriknw closed this in d9ed927 Jan 17, 2020
@patriknw patriknw added this to the 2.6.2 milestone Jan 17, 2020
@patriknw

This comment has been minimized.

Copy link
Member

@patriknw patriknw commented Jan 27, 2020

Users of ScalaTestWithActorTestKit in akka-actor-testkit need to migrate, or create their own copy of the 2.6.1 version of ScalaTestWithActorTestKit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.