Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for log marker in akka streams API dsl #28450

Closed
anshulbajpai opened this issue Jan 6, 2020 · 1 comment
Closed

Support for log marker in akka streams API dsl #28450

anshulbajpai opened this issue Jan 6, 2020 · 1 comment

Comments

@anshulbajpai
Copy link

@anshulbajpai anshulbajpai commented Jan 6, 2020

At the moment, the Akka logging API has support for log markers but that support is missing in the akka-streams API (https://github.com/akka/akka/blob/master/akka-stream/src/main/scala/akka/stream/scaladsl/Flow.scala#L2503)

Is it possible to add this feature so we could add markers while using the Akka streams logging API?

@johanandren

This comment has been minimized.

Copy link
Member

@johanandren johanandren commented Jan 7, 2020

Sounds like it makes sense to support that, but not obvious how to add such support in a binary compatible way since the existing flow API uses default params. Will require some thinking to get it right. Please open up a PR if you are interested in trying to add support @anshulbajpai

duxet added a commit to duxet/akka that referenced this issue Mar 2, 2020
johanandren added a commit that referenced this issue Mar 5, 2020
@johanandren johanandren added this to the 2.6.4 milestone Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.