#3206 - Adding expectTerminated #1314

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@viktorklang
Akka Project member

No description provided.

@patriknw
Akka Project member

JavaTestKit?

@akka-ci
Akka Project member

Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/830/

@viktorklang
Akka Project member

Something like:

public Terminated expectTerminated(FiniteDuration max, ActorRef target, Boolean existenceConfirmed) {
return p.expectTerminated(
target,
max,
(existenceConfirmed == null) ? Option.none() : Option.some(existenceConfirmed));
}

@patriknw
Akka Project member

why not Option.apply(existenceConfirmed)?

@viktorklang
Akka Project member

Lemme try :)

@akka-ci
Akka Project member

jenkins job akka-pr-validator: Success - https://jenkins.akka.io/job/akka-pr-validator/830/

@viktorklang
Akka Project member

Done!

@viktorklang
Akka Project member

:)

@patriknw
Akka Project member

yes, that is better
👍

@akka-ci
Akka Project member

Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/832/

@akka-ci
Akka Project member

jenkins job akka-pr-validator: Success - https://jenkins.akka.io/job/akka-pr-validator/832/

@rkuhn

LGTM

@bantonsson bantonsson commented on an outdated diff Apr 9, 2013
akka-testkit/src/main/java/akka/testkit/JavaTestKit.java
@@ -456,10 +458,19 @@ public void expectNoMsg(FiniteDuration max) {
p.expectNoMsg(max);
}
+
+ /**
+ * Assert that the given ActorRef is Terminated within the specified time.
+ * Don't forget to 'watch' it first!
+ */
+ public Terminated expectTerminated(FiniteDuration max, ActorRef target) {
+ return p.expectTerminated(target, max);
+ }
@bantonsson
bantonsson Apr 9, 2013

It would be nice with a default timeout version as well expectTerminated(ActorRef target) just like expectMsgEquals et.c.

@bantonsson
Akka Project member

LGTM

@drewhk
Akka Project member

Nice, +1

@akka-ci
Akka Project member

Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/832/

@akka-ci
Akka Project member

jenkins job akka-pr-validator: Success - https://jenkins.akka.io/job/akka-pr-validator/832/

@viktorklang
Akka Project member

rebased on top of master

@akka-ci
Akka Project member

Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/839/

@akka-ci
Akka Project member

jenkins job akka-pr-validator: Failed - https://jenkins.akka.io/job/akka-pr-validator/839/
sad kitty

@viktorklang
Akka Project member

Kitteh, you are no gud today.

@viktorklang
Akka Project member

PLS REBUILD ALL

@akka-ci
Akka Project member

Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/839/

@akka-ci
Akka Project member

jenkins job akka-pr-validator: Failed - https://jenkins.akka.io/job/akka-pr-validator/839/
sad kitty

@bantonsson
Akka Project member

This one is still building. The Kitteh keeps picking up old runs when the commit date is in the past. We need to migrate to the new Kitteh.

@viktorklang
Akka Project member

Ok, I'll create a new PR

@viktorklang viktorklang closed this Apr 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment