=act Locale unaware method in Helpers. #20412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the repo owners verify this patch? |
| @@ -14,7 +14,11 @@ import java.util.Locale | |||
|
|
|||
| object Helpers { | |||
|
|
|||
| val isWindows: Boolean = System.getProperty("os.name", "").toLowerCase(Locale.ROOT).indexOf("win") >= 0 | |||
| implicit class LocaleUnawareString(s: String) { | |||
There was a problem hiding this comment.
this is costly and magic, please don't add conversions to add methods :-)
just Helpers.toRootLowerCase would be good
|
Could you grep the project for the |
|
done, except on the http module as discussed. |
|
OK TO TEST |
|
LGTM |
akka-ci
added
validating
|
Test FAILed. |
|
fixed |
akka-ci
added
validating
|
LGTM |
akka-ci
added
tested
|
Test PASSed. |
|
LGTM, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split from #20406