GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intended for discussions, not merge (yet)
looked at the sharding api prototype...
we should probably not qualify the classes with Typed, already a separate package
as I argued in the ticket it is not an ActorRef, because it doesn't have the same kind of lifecycle and semantics as an ActorRef
we probably have to support ask, but not watch
allocationStrategy, we might have some overloads with default values also
role and dataCenter are also missing
I went for one simplest possible and one with all the bells and whistles, guess I missed a few whistles though.
Maybe fold more things into settings, or provide a builder-type and a single API entry point instead of many different overloads?
or move it to the extension instance, and have typeName: String param instead of region: ActorRef ?
Cleanup of imports
Moved internals into a package of their own
Fix for awaitAssert and Java return null usage
Yeah, I know, my brain doesn't really work today:
result != failed
Actually fix awaitAssert
@ktoso I have merged this now, it still contained the sharding stuff, so you have to solve that when rebasing your PR
Excellent, will do :-)