New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ActorContext#schedule with scheduleOnce #25869

Merged
merged 3 commits into from Nov 6, 2018

Conversation

Projects
None yet
6 participants
@dwijnand
Member

dwijnand commented Nov 5, 2018

Deprecate the former

@akka-ci akka-ci added validating tested and removed validating labels Nov 5, 2018

@akka-ci

This comment has been minimized.

Collaborator

akka-ci commented Nov 5, 2018

Test PASSed.

@dwijnand

This comment has been minimized.

Member

dwijnand commented Nov 5, 2018

Self to-do: check usages and replace, to avoid deprecation messages.

@chbatey

chbatey approved these changes Nov 5, 2018

LGTM

def scheduleOnce[U](delay: Duration, target: ActorRef[U], msg: U): akka.actor.Cancellable
@Deprecated
@deprecated("Use scheduleOnce", since = "2.5.18")

This comment has been minimized.

@chbatey

chbatey Nov 5, 2018

Member

As this is typed you can just remove and we'll add a note to the release notes

This comment has been minimized.

@chbatey

chbatey Nov 5, 2018

Member

Or make sure that the docs don't include any schedule

This comment has been minimized.

@hepin1989

hepin1989 Nov 5, 2018

Contributor

vote for just remove it.

This comment has been minimized.

@dwijnand

dwijnand Nov 5, 2018

Member

OK, sure.

@patriknw

looking good, after removal of deprecated

dwijnand added some commits Nov 5, 2018

@akka-ci

This comment has been minimized.

Collaborator

akka-ci commented Nov 5, 2018

Test PASSed.

@raboof

raboof approved these changes Nov 6, 2018

@raboof raboof merged commit 934a28b into akka:master Nov 6, 2018

3 checks passed

Jenkins PR Validation Test PASSed. 1526 tests run, 11 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@dwijnand dwijnand deleted the dwijnand:deal-with-ActorContext.schedule branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment