Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ask timeout from Timeout to Duration in typed javadsl. #25975

Merged
merged 2 commits into from Nov 30, 2018
Merged

Change ask timeout from Timeout to Duration in typed javadsl. #25975

merged 2 commits into from Nov 30, 2018

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Nov 26, 2018 •
edited

refs:#25816

@He-Pin
Copy link
Member Author

He-Pin commented Nov 26, 2018

I found the API lack doc or doc about the parameters.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Nov 26, 2018
@akka-ci
Copy link

akka-ci commented Nov 26, 2018

Test PASSed.

patriknw
patriknw reviewed Nov 26, 2018
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, one small nitpick

akka-actor-typed/src/main/scala/akka/actor/typed/scaladsl/ActorContext.scala Outdated
@@ -167,7 +167,7 @@ trait ActorContext[T] extends akka.actor.typed.ActorContext[T] { this: akka.acto
* *Warning*: This method is not thread-safe and must not be accessed from threads other
* than the ordinary actor message processing thread, such as [[scala.concurrent.Future]] callbacks.
*/
def setReceiveTimeout(d: FiniteDuration, msg: T): Unit
def setReceiveTimeout(receiveTimeout: FiniteDuration, msg: T): Unit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps timeout: to not repeat too much from the method name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I aliased it with the latter responseTimeout in the ask method.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patriknw Done.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR is currently being validated by Jenkins labels Nov 26, 2018
@akka-ci
Copy link

akka-ci commented Nov 26, 2018

Test PASSed.

1 similar comment
@akka-ci
Copy link

akka-ci commented Nov 26, 2018

Test PASSed.

patriknw
patriknw approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw requested a review from helena November 27, 2018 14:59
chbatey
chbatey approved these changes Nov 30, 2018
View reviewed changes
Copy link
Member

@chbatey chbatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chbatey chbatey merged commit 68dc288 into akka:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

@chbatey chbatey chbatey approved these changes

@helena helena Awaiting requested review from helena

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@He-Pin @akka-ci @patriknw @chbatey