Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala 2.13.0-M5 support #26043

Merged
merged 8 commits into from Jan 11, 2019
Merged

scala 2.13.0-M5 support #26043

merged 8 commits into from Jan 11, 2019

Conversation

@raboof
Copy link
Member

raboof commented Dec 4, 2018

Refs #25105

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 4, 2018

Test FAILed.

@raboof raboof force-pushed the scala-2.13.0-M5 branch from c70ce36 to dd8c0ed Dec 5, 2018
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 5, 2018

Test PASSed.

Copy link
Member

patriknw left a comment

Great work, first round of comments.
My comments probably applies to more places than what I spotted so look for similar patterns.

@akka-ci akka-ci added validating and removed tested labels Dec 5, 2018
Copy link
Member

patriknw left a comment

nice that it's not too much from collection.compat

@patriknw patriknw added the wip label Dec 5, 2018
@akka-ci akka-ci added tested and removed validating labels Dec 5, 2018
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 5, 2018

Test PASSed.

@raboof raboof force-pushed the scala-2.13.0-M5 branch from eeb72a2 to ba753f0 Dec 5, 2018
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 5, 2018

Test PASSed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Dec 5, 2018

Test PASSed.

Copy link
Member

dwijnand left a comment

Nice work. Some thoughts.

raboof and others added 7 commits Nov 21, 2018
see scala/bug#10973 for indexWhere/indexOf
Based on f53c843
Manually eta-expand see scala/scala-collection-compat#131

MapLike => Map

Rewrite filterKey with ApplyInfix syntax

Manually fix scala/bug#11033

Manually fix compat layer

since it's 2.13, it's not picked up by scalafix
Clearer imports in TcpDnsClient

Accept SVG's when checking if diagrams were generated

Fix akka-actor MiMa issues

akka-testkit scalafix changes

Update scalatest to 2.13-released snapshot

akka-stream scalafix changes

Update ssl-config

To version that's released with -M5

Take elements directly out of buffer

Manually fix immutable.Seq / Doc link

Make sure the right Concat, Sink is imported

akka-stream binary compat

akka-stream-testkit scalafix

akka-actor-tests scalafix

Eta-expensions
@raboof raboof force-pushed the scala-2.13.0-M5 branch from 45251ac to dac5563 Jan 11, 2019
@akka-ci akka-ci added validating and removed tested labels Jan 11, 2019
Copy link
Member

patriknw left a comment

LGTM after -Ywarn-unused

@@ -83,7 +83,7 @@ object AkkaBuild {

private def allWarnings: Boolean = System.getProperty("akka.allwarnings", "false").toBoolean

final val DefaultScalacOptions = Seq("-encoding", "UTF-8", "-feature", "-unchecked", "-Xlog-reflective-calls", "-Xlint", "-Ywarn-unused")
final val DefaultScalacOptions = Seq("-encoding", "UTF-8", "-feature", "-unchecked", "-Xlog-reflective-calls", "-Xlint")

This comment has been minimized.

Copy link
@patriknw

patriknw Jan 11, 2019

Member

@raboof can we enable "-Ywarn-unused" again?

fix akka-actor-tests compile errors

some tests still fail though

Fix test failures in akka-actor-test

Manually work arround missing implicit Factory[Nothing, Seq[Nothing]]

see scala/scala-collection-compat#137

akka-remote scalafix changes

Fix shutdownAll compile error

test:akka-remote scalafix changes

akka-multi-node-testkit scalafix

Fix akka-remote-tests multi-jvm compile errors

akka-stream-tests/test:scalafix

Fix test:akka-stream-tests

Crude implementation of ByteString.map

scalafix akka-actor-typed, akka-actor-typed-tests

akka-actor-typed-tests compile and succeed

scalafix akka-camel

scalafix akka-cluster

akka-cluster compile & test

scalafix akka-cluster-metrics

Fix akka-cluster-metrics

scalafix akka-cluster-tools

akka-cluster-tools compile and test

scalafix akka-distributed-data

akka-distributed-data fixes

scalafix akka-persistence

scalafix akka-cluster-sharding

fix akka-cluster-sharding

scalafix akka-contrib

Fix akka-cluster-sharding-typed test

scalafix akka-docs

Use scala-stm 0.9 (released for M5)

akka-docs

Remove dependency on collections-compat

Cherry-pick the relevant constructs to our own
private utils

Shorten 'scala.collections.immutable' by importing it

Duplicate 'immutable' imports

Use 'foreach' on futures

Replace MapLike with regular Map

Internal API markers

Simplify ccompat by moving PackageShared into object

Since we don't currently need to differentiate between 2.11 and

Avoid relying on 'union' (and ++) being left-biased

Fix akka-actor/doc by removing -Ywarn-unused

Make more things more private

Copyright headers

Use 'unsorted' to go from SortedSet to Set

Duplicate import

Use onComplete rather than failed.foreach

Clarify why we partly duplicate scala-collection-compat
@raboof raboof force-pushed the scala-2.13.0-M5 branch from dac5563 to d274e03 Jan 11, 2019
@akka-ci akka-ci added tested and removed validating labels Jan 11, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Jan 11, 2019

Test PASSed.

@akka-ci akka-ci added needs-attention and removed tested labels Jan 11, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Jan 11, 2019

Test FAILed.

@raboof

This comment has been minimized.

Copy link
Member Author

raboof commented Jan 11, 2019

PLS BUILD

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Jan 11, 2019

Test PASSed.

@raboof raboof merged commit c109759 into master Jan 11, 2019
4 checks passed
4 checks passed
Jenkins PR Validation Test PASSed. 8130 tests run, 498 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@patriknw

This comment has been minimized.

Copy link
Member

patriknw commented Jan 11, 2019

Great work here @raboof @MasseGuillaume @SethTisue !

@patriknw patriknw mentioned this pull request Jan 23, 2019
8 of 14 tasks complete
@chbatey chbatey deleted the scala-2.13.0-M5 branch Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.