Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Behaviors.logMessages implementation #26238
This PR provides a new Akka Typed
I have a few questions:
Should this implementation check that
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.
For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!
I think the original reason for having a config property is to be able to have the
That reason is still valid for Typed, but I think it would be more useful to have a way to enable/disable individual
I also wonder if we should make it possible to pass in a custom
Apart from this the implementation and everything in this PR is looking good.
johanandren left a comment
Great work, added a few thoughts.
Would be good if the Java API was at least touched from test code, I think compile only would be fine, in