Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Rename start/endContextPropagation functions to asFlow/Source.. #26353
To match FlowWithContext.asFlow
Main changes in
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.
For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!
The whole "with context" is marked as ApiMayChange so add mima filters to akka-stream/src/main/mima-filters/2.5.20.backwards.excludes
(it will probably be 2.5.21 before this is merged so then it should be in 2.5.21.backwards.excludes)
Feb 14, 2019
jrudolph left a comment •
I think it's good for me. The new name is pretty explicit (while I found the old names more descriptive).
As we have decided and agreed on the names back and forth now quite a few times let's collect a few more votes this time so that we can call it final this time.