Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport new serializers from 2.6 #27331

Merged
merged 3 commits into from Jul 12, 2019

Conversation

@patriknw
Copy link
Member

commented Jul 11, 2019

This is not a trivial cherry-pick backport so would be good with review.

A few new serializers were added in 2.6.0-M5:

  • BooleanSerializer
  • 4 new messages for Cluster Sharding queries in ClusterShardingMessageSerializer
  • ThrowableNotSerializableException in MiscMessageSerializer
  • TimeoutException in MiscMessageSerializer

Those were originally added in #27306 and #27285

Backported here for 2.5.24 to support deserialization in rolling update to 2.6.0.
Those are not enabled for serialization (toBinary), see issue #27330 for enabling in a later version, but that is not strictly needed.

patriknw added some commits Jul 9, 2019

Serialization for more Cluster Sharding query messages
* GetClusterShardingStats
* ClusterShardingStats
* GetCurrentRegions
* CurrentRegions

(cherry picked from commit 92bef51)

but not enabled for serialization (toBinary) yet, see issue #27330
Add BooleanSerializer, but not enabled for serialization
* added in 2.6.0, added in 2.5.24 for deserialization to support rolling update
* see issue #27330 for enabling it for toBinary
Add ThrowableNotSerializableException and TimeoutException in MiscMes…
…sageSerializer

* but not enabled for serialization
* added in 2.6.0, added in 2.5.24 for deserialization to support rolling update
* see issue #27330 for enabling it for toBinary

@patriknw patriknw added the backport label Jul 11, 2019

@patriknw patriknw added this to the 2.5.24 milestone Jul 11, 2019

@akka-ci akka-ci added validating tested and removed validating labels Jul 11, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2019

Test PASSed.

@chbatey
Copy link
Member

left a comment

LGTM

@patriknw patriknw merged commit 07c9713 into release-2.5 Jul 12, 2019

3 checks passed

Jenkins PR Validation Test PASSed. 5978 tests run, 36 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@patriknw patriknw deleted the wip-more-serializers-2.5-patriknw branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.