Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of the `toClassic` adapters for typed #27650

Merged
merged 2 commits into from Sep 6, 2019

Conversation

@johanandren
Copy link
Member

johanandren commented Sep 6, 2019

Refs #27649

@akka-ci akka-ci added the validating label Sep 6, 2019
Copy link
Member

patriknw left a comment

first scan looking good

@akka-ci akka-ci added needs-attention and removed validating labels Sep 6, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Sep 6, 2019

Test FAILed.

@johanandren

This comment has been minimized.

Copy link
Member Author

johanandren commented Sep 6, 2019

I thought I would just rename the public ones and deprecate the old but it was easier to just search-replace-rename all occurrences.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Sep 6, 2019

Test PASSed.

@johanandren johanandren marked this pull request as ready for review Sep 6, 2019
Copy link
Member

patriknw left a comment

LGTM

@raboof
raboof approved these changes Sep 6, 2019
@johanandren johanandren added this to the 2.5.26 milestone Sep 6, 2019
@johanandren johanandren merged commit 47a6358 into akka:release-2.5 Sep 6, 2019
3 checks passed
3 checks passed
Jenkins PR Validation Test PASSed. 1767 tests run, 12 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@johanandren johanandren deleted the johanandren:wip-backport-toClassic branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.