Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience method to start timer without key #27875

Merged
merged 2 commits into from Nov 26, 2019
Merged

Conversation

@raboof
Copy link
Member

raboof commented Oct 3, 2019

It is probably common that there is no need to allow different timers
that send the same message, and this makes that more convenient to write.

Updated one method to gather feedback, if we like the change I can apply
it to the others as well.

* in the mailbox when the new timer is started. If you do not want this,
* you can start start them as individual timers by specifying different keys
*/
def startTimerWithFixedDelay(msg: T, delay: FiniteDuration): Unit =

This comment has been minimized.

Copy link
@patriknw

patriknw Oct 3, 2019

Member

I like this idea, I have often used the same case object for key and msg

@akka-ci akka-ci added validating tested and removed validating labels Oct 3, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 3, 2019

Test PASSed.

@helena
helena approved these changes Oct 17, 2019
Copy link
Member

helena left a comment

Looks good but let's fix the run on in the scaladoc.

@patriknw

This comment has been minimized.

Copy link
Member

patriknw commented Oct 17, 2019

and we also need to add this in all places, at least the timer api in Typed

It is probably common that there is no need to allow different timers
that send the same message, and this makes that more convenient to write.

Updated one method to gather feedback, if we like the change I can apply
it to the others as well.
@raboof raboof force-pushed the timerConvenienceMethod branch from e86df18 to 861dec2 Nov 6, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 6, 2019

Test PASSed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 6, 2019

Test FAILed.

Update java/scaladoc, update tests

Not updated classic actors and FSM API's
@raboof raboof force-pushed the timerConvenienceMethod branch from 314a1e7 to acf7518 Nov 6, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Nov 6, 2019

Test PASSed.

@helena

This comment has been minimized.

Copy link
Member

helena commented Nov 6, 2019

This is great btw, definitely needed in typed!

@raboof

This comment has been minimized.

Copy link
Member Author

raboof commented Nov 7, 2019

we also need to add this in all places, at least the timer api in Typed

I now added it everywhere for typed, but not in (persistent) FSM nor in the 'classic' scheduler.

@patriknw

This comment has been minimized.

Copy link
Member

patriknw commented Nov 7, 2019

Sounds ok to limit it to Typed

Copy link
Member

patriknw left a comment

LGTM, good convenience

Copy link
Member

chbatey left a comment

+1

@chbatey chbatey added this to the 2.6.1 milestone Nov 26, 2019
@chbatey chbatey merged commit 4b632c4 into master Nov 26, 2019
3 checks passed
3 checks passed
Jenkins PR Validation Test PASSed. 3259 tests run, 29 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@chbatey chbatey deleted the timerConvenienceMethod branch Nov 26, 2019
@johanandren johanandren mentioned this pull request Nov 27, 2019
@patriknw patriknw mentioned this pull request Dec 6, 2019
navaro1 added a commit to navaro1/akka that referenced this pull request Dec 17, 2019
* Add convenience method to start timer without key

It is probably common that there is no need to allow different timers
that send the same message, and this makes that more convenient to write.

Updated one method to gather feedback, if we like the change I can apply
it to the others as well.

* Add alternative to all typed timer API's

Update java/scaladoc, update tests

Not updated classic actors and FSM API's
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.