Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5 backport] stream: add CancellationStrategy attribute to c… #28008

Merged

Conversation

@jrudolph
Copy link
Member

jrudolph commented Oct 15, 2019

Backport of #27594.

I'm just testing if it still fixes the problems in akka-http.

…fault stage cancellation behaviors

(cherry picked from commit c839b99)
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 15, 2019

Test PASSed.

@jrudolph

This comment has been minimized.

Copy link
Member Author

jrudolph commented Oct 16, 2019

Compilation failed on Scala 2.11, fixing...

@akka-ci akka-ci added validating and removed tested labels Oct 16, 2019
Copy link
Member

patriknw left a comment

looking good but a few questions about mima compat between this and master?

@akka-ci akka-ci added tested and removed validating labels Oct 16, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 16, 2019

Test PASSed.

Also backport the exceptions in SubscriptionWithCancelException
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 16, 2019

Test FAILed.

@akka-ci akka-ci added validating and removed needs-attention labels Oct 16, 2019
Copy link
Member

patriknw left a comment

LGTM

@akka-ci akka-ci added tested and removed validating labels Oct 16, 2019
@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Oct 16, 2019

Test PASSed.

Copy link
Member

johanandren left a comment

LGTM

@jrudolph jrudolph changed the title [2.5 backport] stream: add CancellationStrategy attribute to configure default stage cancellation behaviors [2.5 backport] stream: add CancellationStrategy attribute to c… Oct 16, 2019
@jrudolph jrudolph merged commit 41884ba into akka:release-2.5 Oct 16, 2019
3 checks passed
3 checks passed
Jenkins PR Validation Test PASSed. 4738 tests run, 492 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@jrudolph jrudolph deleted the jrudolph:jr/stream-cancellation-modes-backport-v2 branch Oct 16, 2019
@jrudolph jrudolph added this to the 2.5.26 milestone Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.