Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish operations from InmemJournal #28332

Merged
merged 2 commits into from Jan 13, 2020
Merged

Publish operations from InmemJournal #28332

merged 2 commits into from Jan 13, 2020

Conversation

@patriknw
Copy link
Member

patriknw commented Dec 9, 2019

  • small feature that is useful for verifying that expected events were persisted

If you agree I will update the testing docs for Typed to mention/use this.

Full persistence testkit is in progress in #26825 but this is anyway a useful addition to the existing InmemJournal.

* small feature that is useful for verifying that expected events were persisted
@akka-ci akka-ci added validating tested and removed validating labels Dec 9, 2019
@akka-ci

This comment has been minimized.

Copy link

akka-ci commented Dec 9, 2019

Test PASSed.

Copy link
Member

johanandren left a comment

Looks like a reasonable idea to me.

* also enable serialization test config
@patriknw patriknw marked this pull request as ready for review Dec 16, 2019
@patriknw

This comment has been minimized.

Copy link
Member Author

patriknw commented Dec 16, 2019

Added docs. Ready for final review.

@hepin1989

This comment has been minimized.

JournalOperation?

This comment has been minimized.

Copy link
Member Author

patriknw replied Dec 16, 2019

they are already qualfied with InmemJournal.Operation

Copy link
Member

johanandren left a comment

LGTM

@akka-ci

This comment has been minimized.

Copy link

akka-ci commented Dec 16, 2019

Test PASSed.

@patriknw patriknw requested a review from chbatey Jan 8, 2020
Copy link
Member

chbatey left a comment

Looks good

@patriknw patriknw merged commit cdc45c1 into master Jan 13, 2020
3 checks passed
3 checks passed
Jenkins PR Validation Test PASSed. 1408 tests run, 8 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
@patriknw patriknw deleted the wip-inmem-publish-patriknw branch Jan 13, 2020
@patriknw patriknw added this to the 2.6.2 milestone Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.