Wip docs ∂π #910

Merged
merged 3 commits into from Dec 4, 2012

Projects

None yet

4 participants

@rkuhn

should be back-ported to 2.1

 #2747 - warn against use-dispatcher-for-io  7ee06f4

 #2746 - document provider.getDefaultAddress     ae51754

 #2644 - doc FSM.NullFunction and when-requirements
@viktorklang viktorklang commented on the diff Nov 28, 2012
...code/docs/serialization/SerializationDocTestBase.java
@@ -138,12 +138,7 @@ public DefaultAddressExt(ExtendedActorSystem system) {
}
public Address getAddress() {
- final ActorRefProvider provider = system.provider();
- if (provider instanceof RemoteActorRefProvider) {
- return ((RemoteActorRefProvider) provider).transport().address();
- } else {
- throw new UnsupportedOperationException("need RemoteActorRefProvider");
- }
+ return system.provider().getDefaultAddress();
@viktorklang viktorklang commented on an outdated diff Nov 28, 2012
akka-remote/src/main/resources/reference.conf
@@ -109,6 +109,9 @@ akka {
# (I) EXPERIMENTAL If "<id.of.dispatcher>" then the specified dispatcher
# will be used to accept inbound connections, and perform IO. If "" then
# dedicated threads will be used.
+ #
+ # CAUTION: this might lead to the used dispatcher not shutting down properly!
@viktorklang
viktorklang Nov 28, 2012

I'd change that to: CAUTION: Do not use if you do not exit the JVM as you shut down your ActorSystem, as it will leak threads.

@akka-ci
Akka Project member

Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/149/

@akka-ci
Akka Project member

jenkins job akka-pr-validator: Success - https://jenkins.akka.io/job/akka-pr-validator/149/

@patriknw
Akka Project member

LGTM

@rkuhn rkuhn merged commit 6a803e4 into master Dec 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment