Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rename FSM and TestFSMRef's timerActive_? to isTimerActive. Fixes #2766 #925

Merged
merged 1 commit into from Dec 7, 2012

Conversation

Projects
None yet
4 participants
Contributor

richdougherty commented Dec 5, 2012

(Oops, accidentally closed 921 when updating the branch.)

This pull request is the same but also renames some of the new code that came in pull request 915.

Owner

patriknw commented Dec 5, 2012

LGTM

Collaborator

akka-ci commented Dec 5, 2012

Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/173/

Collaborator

akka-ci commented Dec 5, 2012

jenkins job akka-pr-validator: Success - https://jenkins.akka.io/job/akka-pr-validator/173/

@rkuhn rkuhn commented on an outdated diff Dec 6, 2012

akka-actor/src/main/scala/akka/actor/FSM.scala
@@ -372,7 +372,15 @@ trait FSM[S, D] extends Listeners with ActorLogging {
* timer does not exist, has previously been canceled or if it was a
* single-shot timer whose message was already received.
*/
- final def timerActive_?(name: String) = timers contains name
+ @deprecated("Use isTimerActive() instead.", "2.2")
@rkuhn

rkuhn Dec 6, 2012

Collaborator

I’d include the arguments to show the right arity of the method: isTimerActive(name)

Collaborator

rkuhn commented Dec 6, 2012

apart from the nitpick: LGTM

could you do the same for ThreadPoolBuilder.conf_? and TypedActor.MethodCall.returns<*>_? ?

Collaborator

akka-ci commented Dec 6, 2012

Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/179/

Collaborator

akka-ci commented Dec 6, 2012

jenkins job akka-pr-validator: Success - https://jenkins.akka.io/job/akka-pr-validator/179/

@rkuhn rkuhn added a commit that referenced this pull request Dec 7, 2012

@rkuhn rkuhn Merge pull request #925 from richdougherty/wip-2766-timeractive-rename
Rename FSM and TestFSMRef's timerActive_? to isTimerActive. Fixes #2766
d642fab

@rkuhn rkuhn merged commit d642fab into akka:master Dec 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment