CommittingSpec: add logging #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seglo
approved these changes
Dec 16, 2019
Comment on lines
+446
to
+453
| .committableSource( | ||
| consumerSettings | ||
| .withStopTimeout(100.millis), // this consumer actor needs to stay around to receive the commit | ||
| Subscriptions.assignment(new TopicPartition(topic, partition0)) | ||
| ) | ||
| .take(10) | ||
| // triggers commit timeout as the actor is terminated | ||
| .delay(50.millis) |
There was a problem hiding this comment.
It's good that this resolves the issue, but it looks like it could still arise on systems with slow clocks? We should try repeating this test (i.e. sbt "testOnly thistest -- -DtimesToRepeat=100") to see if it fails occasionally.
More long term we should find a way around the stop timeout for happy-path shutdown scenarios.
There was a problem hiding this comment.
This PR fixes the test, not the issue (and added more information to the commit timeout error).
I'm not sure there is a way to fix this, for how long after emitting data should a source live to receive commits? Should the actor stay around, but the stage complete?
|
Unrelated build error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommittingSpecto keep it from failingIntends to solve #957